[Michael]

It seams like you have skipped the setup of the adtrackz system and went straight for the affiliate setup.

Your right about having to set up a thank you page. The instructions on that are in the docs and also online here:
http://www.apicos.com/site/jamroom_stuff.php?page=jamroom_affiliate_marketing_pack_pg2#171

Give that a go and see if it solves your issues.


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[whodaniel]

I am using MediaPro and so skipped that whole section that says to do so. I do believe that I followed the instruction and installed everything in sequence as outlined. I enabled all of the mods and the integrity check shows them all as being correct. There may be something very basic about it that I am not getting. But, I can assure you that if you can help me to get all the pieces in place, that others should certainly be able to have an easier time of it, yes? I know you are busy, but you are more than welcome to sign in and see what is missing if anything.

[Michael]

If your using mediapro there should be a thank_you.tpl page in your skins directory.

If there isn't then download the newest version from Oinkba.com and that should sort out your issues.


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[webster]

What was updated in the latest release of the Affiliate Marketing Pack? Didn't see a note but saw that it had been updated.


_________________
Customer Retention, who needs to learn this word?

[Michael]

In the latest release the affiliate module now uses hooks to determine sales for the default stuff.

So there is no need to alter any templates to get the affiliate to work. This takes care of the issue of selling subscriptions and starting by offering a free trial.

In the previous releases the affiliate would be granted a percentage of the amount that paypal took. Which on a free trial is zero. So if your paying a flat fee no problem, but if you are paying a percentage of a sale AND offering a free trial the affiliate misses out.

I have updated the documentation in the package itself, but the documentation on my site still says you need to alter templates for the affiliate. I was going to issue an announcement once i could get that sorted, but i've been busy lately.

If you have a free trial, or dont use an Oinkba skin, or want to pay an affiliate each time a member renews their subscription. Get the latest releases.


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[iLoveHouseMusic]

What's new in 1.7 Affiliate pack?

[Michael]

iLoveHouseMusic:

What's new in 1.7 Affiliate pack?

There is a new module in there. apSplitTest

So now instead of 3 modules in the pack, there are 4.

I put up an announcement about apSplitTest here:
http://www.jamroom.net/phpBB2/viewtopic.php?t=40449


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Ken Rich]

I have the Jamroom Affiliate Marketing Pack. I am using the N8Flash Mogul skin, so I actually paid Nate to do the install to avoid compatibility issues. However, I have noticed two issues with this product (so far).

1) Custom URL's are not working, it defaults to the main store. In other words this advertised ability (below in red) does not exist. I have tried individual vault item URL's and artist URL's. In this example, I am trying to link to a client's book but the link takes me to the general store.

An optional extra paramater is url like this:
http://gospel-jukebox.com/apAffiliate.php?mode=track&aid=0&url=http://gospel-jukebox.com/pages/item/vault_id=234(So you can link to any page on the site you like.)

2) In the quota settings there is a HUGE hint button which should simply show a ?. Instead (because of an apparent code typo) it is stretched to show all this below.

affiliate program settings.';myHint.show('help_apAffiliate_override',this)" onmouseout="myHint.hide()" id="apAffiliate_override_help" class="button">?


_________________
Ken

[Michael]

Ill go check the first issue of the redirect not working correctly out now and get back to you.

One issue I can see with it is there is no affiliate id. 'aid=0' the admin user cant be an affiliate. It needs to be a real user id from a quota that has access turned on in their quota settings.

As for #2 that code does not come from the affiliate module. It must be something the skin is doing. Check if its working in something like sage.


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Michael]

ok I have had a look at the url redirect issue and found that the redirecting is working if you use a url like this:
http://gospel-jukebox.com/apAffiliate.php?mode=track&aid=0&url=http://gospel-jukebox.com/jtministries/

but anything with the = sign in it is registering as part of the URL. (see all the other = signs in there)

So if you want to send to a URL that contains an = sign in the destination, you need to do what is called 'urlencoding'

= when it is url encoded becomes %3D so the full url will become:
http://gospel-jukebox.com/apAffiliate.php?mode=track&aid=0&url=http://gospel-jukebox.com/pages/item/vault_id%3D234

This is the issue.

Currently, the URL redirect does not expect to see an = sign in the URL so even the above url will be flagged as malicious code and stripped by the security. I will put the equals sign in as an 'ok' symbol for future releases.


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Michael]

Found it.

If you want to allow the = sign through for yourself before the update comes out, change this line of code:

/modules/apAffiliate/include/class/tracking.class.php line330

Code

else if (!preg_match("/^[0-9a-z\/_\.@~-]*$/i", $parts['path'], $regs))

to

Code

else if (!preg_match("/^[0-9a-z\/_\.@=~-]*$/i", $parts['path'], $regs))

The whole function looks like this:

Code

private function is_url($url) {         $url = substr($url, -1) == "/" ? substr($url, 0, -1) : $url;         if (!$url || $url == "") return false;         if (!($parts = @parse_url($url))) return false;         else {             if ($parts['scheme'] != "http" && $parts['scheme'] != "https" && $parts['scheme'] != "ftp" && $parts['scheme'] != "gopher") return false;             else if (!preg_match("/^[0-9a-z]([-\.]?[0-9a-z])*\.[a-z]{2,4}$/i", $parts['host'], $regs)) return false;             else if (!preg_match("/^([0-9a-z-]|[_])*$/i", $parts['user'], $regs)) return false;             else if (!preg_match("/^([0-9a-z-]|[_])*$/i", $parts['pass'], $regs)) return false;             else if (!preg_match("/^[0-9a-z\/_\.@~-]*$/i", $parts['path'], $regs)) return false;             else if (!preg_match("/^[0-9a-z?&=#,]*$/i", $parts['query'], $regs)) return false;         }         return true;     }

and we just want to add an = sign to the match of the $parts['path'] section of it.

So make that 1 small change and you will be able to use the escaped URL's.

so the whole updated function looks like this:

Code

private function is_url($url) {         $url = substr($url, -1) == "/" ? substr($url, 0, -1) : $url;         if (!$url || $url == "") return false;         if (!($parts = @parse_url($url))) return false;         else {             if ($parts['scheme'] != "http" && $parts['scheme'] != "https" && $parts['scheme'] != "ftp" && $parts['scheme'] != "gopher") return false;             else if (!preg_match("/^[0-9a-z]([-\.]?[0-9a-z])*\.[a-z]{2,4}$/i", $parts['host'], $regs)) return false;             else if (!preg_match("/^([0-9a-z-]|[_])*$/i", $parts['user'], $regs)) return false;             else if (!preg_match("/^([0-9a-z-]|[_])*$/i", $parts['pass'], $regs)) return false;             else if (!preg_match("/^[0-9a-z\/_\.@=~-]*$/i", $parts['path'], $regs)) return false;             else if (!preg_match("/^[0-9a-z?&=#,]*$/i", $parts['query'], $regs)) return false;         }         return true;     }

--edit--
Issue tracker url:
http://www.jamroom.net/index.php?m=td_tracker&o=view&id=1945


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Ken Rich]

Michael:

As for #2 that code does not come from the affiliate module. It must be something the skin is doing. Check if its working in something like sage.

As I said, I paid Nate of N8Flash (the Mogul skin author) to install the ad pack. I showed him this specific issue an he said it wasn't the skin, he said it was a typo in the ad pack coding.

Here is a screenshot of the Quota settings so you can see exactly what I am talking about.




_________________
Ken

[Ken Rich]

Your fix for issue number one was implemented and it worked. Thanks - that was fast and it was written up in a way I could easily follow. Awesome Support!!!


_________________
Ken

[Michael]

I can see the issue. It is also happening in the Nova skin where the help comments are delivered by javascript.

The cause of the issue is the link in the help text. it should read:

Quote:

If this is set to "yes", then profiles in this quota will use the percentages set below instead of the ones set in the affiliate program settings.

where the 'affiliate program settings' is a link to the affiliate programs settings page in your admin area:
apAffiliate.php?mode=settings

But because it is being delivered by javascript the enclosing brackets are not escaping properly.

The solution is to change the enclosing brackets of the link to the same ones that the javascript is using.

I will get this updated in the main module, but for now,
modules/apAffiliate/quota.php line 26 currently reads

Code

jmYesNo('Override Default Settings', 'apAffiliate_override', 'If this is set to &quot;yes&quot;, then profiles in this quota will use the percentages set below instead of the ones set in the <a href=\"/apAffiliate.php?mode=settings\">affiliate program settings</a>.', $quota['apAffiliate_override']);

Change it to

Code

jmYesNo('Override Default Settings', 'apAffiliate_override', 'If this is set to &quot;yes&quot;, then profiles in this quota will use the percentages set below instead of the ones set in the <a href=\'/apAffiliate.php?mode=settings\'>affiliate program settings</a>.', $quota['apAffiliate_override']);

The section that is changing is
<a href=\"/apAffiliate.php?mode=settings\"> to
<a href=\'/apAffiliate.php?mode=settings\'>

The href " is changing to '

The link wont be clickable for you because of the way it is delivered, so if it still causes issues, you can remove the link in the help text all together.

If you want to remove the link that same line would look like this:

Code

jmYesNo('Override Default Settings', 'apAffiliate_override', 'If this is set to "yes", then profiles in this quota will use the percentages set below instead of the ones set in the affiliate program settings.', $quota['apAffiliate_override']);

--edit--
issue tracker:
http://www.jamroom.net/index.php?m=td_tracker&o=view&id=1946


_________________
Michael Ussher
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Ken Rich]

Quote:

The solution is to change the enclosing brackets of the link to the same ones that the javascript is using. The section that is changing is <a href=\"/apAffiliate.php?mode=settings\"> to <a href=\'/apAffiliate.php?mode=settings\'> The href " is changing to ' The link wont be clickable for you because of the way it is delivered, so if it still causes issues, you can remove the link in the help text all together.

The first way of fixing this The href " is changing to ' resulted in me losing access to my quotas with a 500 internal server error. Also, the PHP error log showed this:

[22-Aug-2012 10:36:36] PHP Parse error: syntax error, unexpected '=' in /home/gospelju/public_html/modules/apAffiliate/quota.php on line 26

So I tried your second method which was removing the link all together - that worked - thanks.


_________________
Ken