[SteveX]

I have a module smarty function which uses jrCore_create_page_element to add javascript_href.

The js links appear in the head when I place the smarty function in jrBlog item_list.tpl or similar.

But do not appear when I place the smarty function in a template such as profile_footer.tpl or just inside the body in header.tpl, the scripts do not appear in the head.

Is this the way it is supposed to be or is it not working correctly?
Do smarty functions that add js and css only do so from within a module template not a skin template?

Thanks


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Brian]

The problem is that by the time the core "sees" the function in the skin template, it has already processed all of the smarty template variables that are going to be included, so it can't go back and add your href to the meta.tpl file. Instead, you want to define the JavaScript as a module feature in your module's init function - you can check the $_post in your init function if you only want to include the JavaScript on specific views or templates.

Let me know if that helps.

- Brian


_________________
Make sure and check out:
* The Jamroom FAQ
* The Jamroom Documentation

[SteveX]

Thanks Brian, but javascript_href doesn't work with registering a module feature.

I need to link to google maps api scripts, and only want it to appear in the head when there is a map on that page. I am probably overlooking something obvious, but I still can't see it.

A map is created using a smarty function which can be placed in any template depending on what is being mapped (map is a custom field, so could be attached to a jrBlog item in item_list.tpl, or the jrProfile item in the skin profile_footer.tpl, or just in the site footer with hardcoded coordinates, depending on what the site is choosing to show maps for).

Any ideas?


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Brian]

SteveX:

Thanks Brian, but javascript_href doesn't work with registering a module feature. I need to link to google maps api scripts, and only want it to appear in the head when there is a map on that page. I am probably overlooking something obvious, but I still can't see it. A map is created using a smarty function which can be placed in any template depending on what is being mapped (map is a custom field, so could be attached to a jrBlog item in item_list.tpl, or the jrProfile item in the skin profile_footer.tpl, or just in the site footer with hardcoded coordinates, depending on what the site is choosing to show maps for). Any ideas?

It does work - just register the full URL - i.e.

Code

jrCore_register_module_feature('jrCore','javascript','YourModule','http://site.com/javascript.js');

You can use an if/else check in your init() function if you need to selectively include it.

Let me know if that helps.

- Brian


_________________
Make sure and check out:
* The Jamroom FAQ
* The Jamroom Documentation

[SteveX]

Ah, it does work like that Thankyou!

But I still don't see how I can selectively include it - there's no way of knowing what a website will want to map or where they will use the smarty function.

Any ideas?


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Brian]

I think in that case you'll just need to include it on all pages - if you are worried it will "break" on pages where there is no map (i.e. it has a ready function assuming a DOM element), wrap the entire js in a try/catch block and that will fix that.

Let me know if that helps.

- Brian


_________________
Make sure and check out:
* The Jamroom FAQ
* The Jamroom Documentation

[SteveX]

Ok, thanks.

Do you think something like this would also work?

Within the smarty function, check if its a skin template,
If it is then check if the google script has been loaded (it has a flag),
If it hasnt already been loaded then add the <script tag to the html, and set the flag so it doesnt appear a 2nd time if there are further maps later in the page.


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Brian]

If you can figure that out, then it would work - the problem is that the meta.tpl file has already been processed by the time it gets to your smarty function call. You can of course do it inline in the page (or add it in the footer) and that should work.

Hope this helps!

- Brian


_________________
Make sure and check out:
* The Jamroom FAQ
* The Jamroom Documentation

[SteveX]

I'll give it a try.

I've found why sending js to the footer wasn't working:

This is from footer.tpl in elastic, flashback and nova:

Code

{if isset($javascript_footer_function)} <script type="text/javascript">         {$javascript_ready_function}return true; </script> {/if}

{$javascript_ready_function} should be {$javascript_footer_function}


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Brian]

SteveX:

I'll give it a try. I've found why sending js to the footer wasn't working: This is from footer.tpl in elastic, flashback and nova: Code {if isset($javascript_footer_function)} <script type="text/javascript">         {$javascript_ready_function}return true; </script> {/if} {$javascript_ready_function} should be {$javascript_footer_function}

Good catch - I'll get that fixed up.

Thanks!

- Brian


_________________
Make sure and check out:
* The Jamroom FAQ
* The Jamroom Documentation

[SteveX]

SteveX:

Within the smarty function, check if its a skin template, If it is then check if the google script has been loaded (it has a flag), If it hasnt already been loaded then add the <script tag to the html, and set the flag so it doesnt appear a 2nd time if there are further maps later in the page.

This works pretty well!


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.