[Dazed]

So I am working on updating a skin from v1 to v1.0.1 and I am kind of scratching my head for an easier way to do this. The reason being is that skin="Skin_Name" in the templates should probably be a variable set by the skin that is chosen. So maybe skin={$active_skin}? The reason being is that when updates are released, if a skin has been cloned, every file will be different due to the skin name as well as directories. That means that every updated file will need to be changed to the correct skin name. At this stage cloning is actually more work and the old way of renaming the skin is easier.

Thoughts?

[SteveX]

For me that's a 30 second job using a text editor to find and replace in the new directories. (using bbedit)

The bonus is that it shows you all of the version changes as well. Almost any text editor should do this, look for diff or compare folders in the text editor.


_________________
Kulshi Mezian!

"Stranger from another planet, welcome to our hole. Just strap on your guitar and we'll play some rock and roll"

Ultrabubble create things.

[Dazed]

SteveX:

For me that's a 30 second job using a text editor to find and replace in the new directories. (using bbedit) The bonus is that it shows you all of the version changes as well. Almost any text editor should do this, look for diff or compare folders in the text editor.

Hey Steve - I used TextPad and have been using that to do the diff on the files. The current release looks like changed files were not included. So I just compared the last version to the new version for the entire skins dir. Once I located the changed files, then I compared them to my changed templates. If we used variables it would probably be easier. $active_skin could be used throughout the templates.

[Douglas]

I think the only place skin=SKIN_NAME is used is inside the language function...

Code

{jrCore_lang skin="jrProJam" id="..." default="..."}

I believe there is a {jrCore_active_skin} variable available, but I don't know if it will work inside the language function.


_________________
Douglas Hackney
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Douglas]

That doesn't work, so don't try it.


_________________
Douglas Hackney
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Dazed]

Thanks all. I will figure something out. I still had a copy of beyond compare on my laptop so will look at that also. The skin=skin_name is used all over the place as well as skin_name/img/ paths. So when doing compares you really need to do a replace all on every change file to find the real changes.

I need to look at this today since I lost the CSS on my cloned skin and it is all over the place now. Must be in the header file I am guessing.

[Douglas]

This does work though...

Code

{jrCore_lang skin=$_conf.jrCore_active_skin .....}

_________________
Douglas Hackney
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Dazed]

Thanks Douglas. For now I was able to get a rhythm on updating my cloned skin. I still had Beyond Compare on my laptop so I saved off my clone, removed it, cloned the updated skin, downloaded it, compared each file from my original clone and just made updates from there.

[Douglas]

I'm actually updating all the skins to use this now.


_________________
Douglas Hackney
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Dazed]

Douglas - Before you get too involved, Brian posted on this thread - http://www.jamroom.net/phpBB2/viewtopic.php?t=42567 where I was asking about change files thyat he has added this to be looked at. I just hate for you to do something twice lol. I would make sure you guys are on the same page hehe.

I appreciate you jumping on this though. It will make things a lot easier.

[Douglas]

Yes, I saw his ticket.


_________________
Douglas Hackney
Jamroom Network Team Member: http://www.jamroom.net
Priority Support: http://www.jamroom.net/Support_Center

[Dazed]

You are good