Image sizes
Design and Skin Customization
My pleasure, I'm glad to be able to!
Forum Activity for @ultrajam
Image sizes
Design and Skin Customization
Sorry Brian, I had the thread still open when I noticed my mistake, so I just edited it.
All looks good to me.
Image sizes
Design and Skin Customization
deleted this comment, I'm not reading straight today
updated by @ultrajam: 04/28/14 08:05:41AM
Image sizes
Design and Skin Customization
I've tested it extensively and haven't seen distortion at all since completing it. It took quite a while to get right.
Make sure you are not seeing cached images when looking at an image processed on the url, and that if you are looking at images in templates that they are freshly uploaded - once the image has been created it will already be distorted.
When looking at an image directly on the url change the aspect ratio for every page reload to make sure the image is recreated each time.
I still found I had to do that even with emptying the image cache every time.
updated by @ultrajam: 04/28/14 06:57:09AM
Image sizes
Design and Skin Customization
Yes, the width needs to be cropped to maintain the aspect ratio and maintain the max image dimension (switches from width to height or vice versa but is still an small/xlarge/xxlarge image).
Try out my code above (it replaces the if (strpos($_post['crop'], ':')) section at around line 952, and it does do the job perfectly as far as I can see.
Image sizes
Design and Skin Customization
Mostly ok, but it becomes letterboxed/filled at 16:11
https://www.jamroom.net/user/image/user_image/6/xxxlarge/crop=16:11
Image sizes
Design and Skin Customization
I get the same on my local site though.
The above code fixes it for me.
Image sizes
Design and Skin Customization
This is distorted for me on the Nova demo:
http://demo.jamroom.net/jrNova/blog/image/blog_image/4/large/crop=16:9
The original isn't distorted:
http://demo.jamroom.net/jrNova/blog/image/blog_image/4/large
Image sizes
Design and Skin Customization
I've been testing that on url images like
/blog/image/blog_image/4/xxlarge/crop=9:18
So far it holds up for blog images of all sizes and aspect ratios and original upload aspect ratio.
The cache problem I was seeing seems to be firefox.
After emptying the jr image cache, ff cache will show a previous version for the same url. You can get around that by changing the image id, size or aspect ratio in the url each time so its always a new url; crop=122:133 crop=122:136 crop=1342:1396 etc
