jrPoll embed and jrUpimg_allowed
Jamroom Developers
SteveX:
Ok, thanks Michael and Brian.
I’ve got a few notes on things I’ve noticed looking through code and validation. None of them are important or cause errors (apart from validation) so I’ll post them here rather than creating separate threads (unless you really want separate threads):
———————
In each of the the section templates, if there is no title entered <a id=""></a> is printed in the html which causes a validation error.
This can be fixed with a check:
{if $doc_title_url}<a id="{$doc_title_url}"></a>{/if}
———————
In item_category_index.tpl
{jrCore_lang module="jrDocs" id="53" default="Documentation" assign="lang_documentaton"}
{jrCore_page_title title="`$lang_documentaton` - `$category` - `$profile_name`"}lang_documentaton looks like a typo, although obviously it works ok.
———————
jrDocs_item_index_order_button
we get alt="" on an a tag, fails validation
———————
And a typo in jrEmbed
The language string in en-US.php is
$lang[1] = 'Embed this Media';
Whilst the default text in tabs.tpl is
<title>{jrCore_lang module="jrEmbed" id="1" default="Insert Media"}</title>
Separate thread not required, I'll go get these fixed up now. Thanks steve.
SteveX:...Also, I’m wondering if jrBlog may be missing a quota.php file - it was there as a stub until jrBlog-release-1.0.10 but hasn’t appeared in the past 3 releases. Maybe other code has changed and a quota.php stub is no longer needed?...
Yeah if its only the 'active' setting for quotas, you can skip the quota.php file and just use an _init() function.
This is the init function for jrPoll (It has a quota.php file too.) but _init() looks like this:
$_options = array(
'label' => 'Can Create Polls',
'help' => 'If checked, users in this quota will be able to create Polls.'
);
jrCore_register_module_feature('jrCore', 'quota_support', 'jrPoll', 'on', $_options);
That translates into the config variable $_conf['quota_jrPoll_allowed'] .
Any additional fields needed would go into the quota.php file. Or if you can use the quota.php file to not use that register feature function. Think the reason was to avoid having blank functions in quota.php, but there might have been another reason. Can't remember off the top of my head.
