Menu

Hey Micheal

Main menu doesn't remember what page your on, ie it always highlights the home page.

http://tinypic.com/r/2hd5n9v/8
updated by @garymoncrieff: 12/22/16 11:55:59AM

Might also be nice if the menu supported panel elements, mimicking a mega menu layout as such.

This could push it over the top.
updated by @garymoncrieff: 12/22/16 11:55:59AM

You rock gary! Thanks for helping with this.

I'll check these out.

Could you explain that second one a bit more please? mega menu layout?
updated by @michael: 12/22/16 11:55:59AM

If you have ever used a mega menu or something similar it allows you to add widget like things in columns to a menu.

see this example for wordpress, http://wpmegamenu.com/ but there are also JS based ones on codecanyon as well.
updated by @garymoncrieff: 12/22/16 11:55:59AM

not impossible. Wondering if all the extra bits would get used. Most perplexed by how to make the interface. Got any examples/suggestions of a good system.
updated by @michael: 12/22/16 11:55:59AM

I will think about it and get back to you.
updated by @garymoncrieff: 12/22/16 11:55:59AM

I'm in the middle of a system update thats taking a while to complete. Will actually start coding once its done. That menu highlight update should be a quick one.
updated by @michael: 12/22/16 11:55:59AM

My early thinking is something along the lines of this.

For each menu item, there is a checkbox,

Widgetised Menu

if checked, ask to set a layout for menu widget area. Once this is done, load a preview of the menu and allow widgets to be added.

It's after midnight here and my eyes are getting square so I will see if I can come up with mockup images tomorrow.
updated by @garymoncrieff: 12/22/16 11:55:59AM

The menu should be highlighting the active item. I've re-uploaded all the modules and the slate skin so if you want to click RELOAD you'll have the latest version if you dont already.

ACP -> MARKETPLACE -> TOOLS -> RELOAD MODULES OR SKINS -> (slate, panel, widget, menu)
updated by @michael: 12/22/16 11:55:59AM

Thanks it's working now.
updated by @garymoncrieff: 12/22/16 11:55:59AM

Not sure I am using this correctly.

I discovered it's quite easy to add a panel area to any existing template, however doing this means the menu doesn't stay highlighted when active even with the new version.

I envision that supplying templates with panel area will be the best way to provide additional skins based on this.
updated by @garymoncrieff: 12/22/16 11:55:59AM

The Menu module and the Panel module are not connected, they just work well together.

Sure you can add a panel to an existing location. I would expect that it would increase your support requests when users ask to be able to alter that area.

---
There is no 'correctly' there is only 'currently', how do you want it to work.

Here's what I envisioned and my thoughts going forward.

What I expected skin developers would want to do would be to create a layout by using the system. They would build their site the way they wanted it by creating custom templates and putting them in the /skin/( jrSlate renamed )/* folder and linking to them from the "template" section of the widget.

Once the system was as they wanted it, they would EXPORT the panel structure via:
SITE BUILDER -> PANELS -> TOOLS -> EXPORT

and package that with the skin. When the skin was activated that structure would be IMPORTed to give what the skin designer imagined to the next person.

So a skin designer in the case of the SITE BUILDER system would be creating the extra template options for the widgets.
updated by @michael: 12/22/16 11:55:59AM

It should, the highlighting is only a check to see if the location matches the location of the link, if it does, it highlights.

So cases where you have the menu link in a secondary level of the menu, then nothing will be highlighted because its hidden.

If you can give me an example of what your after, I can try to get it incorporated.
updated by @michael: 12/22/16 11:55:59AM

I think it will become a lot clearer when the widgets shown in the screenshots are released and I can see how these are set up.
updated by @garymoncrieff: 12/22/16 11:55:59AM

I've got a bunch of widgets, but am re-thinking how they should work. My current thinking is to move their functionality into jrEmbed structure instead so the functionality can be used in more locations.
updated by @michael: 12/22/16 11:55:59AM

Yes moving them to jrEmded would indeed be better.
updated by @garymoncrieff: 12/22/16 11:55:59AM

I think it must be a line of code being injected onto panel pages that is missing from templates I create manually, and that's why they don't show as active on the menu?
updated by @garymoncrieff: 12/22/16 11:55:59AM

got a link?

--edit--

It should be irrespective of panels. The menu should see if the url matches the url the tab points to and if it does then it ads an 'active' class.

another way to say it: If the url on the menu item is the same as the url that is coming in, then it adds an active class.
updated by @michael: 12/22/16 11:55:59AM

http://plugu.co.uk/development/news
updated by @garymoncrieff: 12/22/16 11:55:59AM

interesting. music and blogs stay hilighted while news and home don't.

I'll try to recreate that here. Thanks. Let you know what I find.
updated by @michael: 12/22/16 11:55:59AM

I've added some more checks to try to better catch the active menu item in jrMenu 1.0.3.

All locations should be hilighted now.
updated by @michael: 12/22/16 11:55:59AM

Can report back that all menu links that weren't showing active are now showing active and will report back if I come across anything else.

Nice job.
updated by @garymoncrieff: 12/22/16 11:55:59AM

Thanks Gary.
updated by @michael: 12/22/16 11:55:59AM