Elastic 2 Footer Issue

blindmime
@blindmime
6 years ago
772 posts
At some point the variable to output the website info in the copyright area in the footer was incorrectly changed to "{$_conf.jrCore_system_url}", so nothing is output. It probably should be "{$_conf.jrCore_system_name}". See attachment.

You might take a look throughout the footer code as there are other issues. For instance the twitter link is malformed: https://twitter.com/{$_conf.bbElastic2_twitter_url is doubling the "https://twitter.com/" so you get an error. The other social links are formed the same way.
screenshot_1207.png
screenshot_1207.png  •  39KB


updated by @blindmime: 04/25/18 03:47:12PM
douglas
@douglas
6 years ago
2,767 posts
We'll get the {$_conf.jrCore_system_url} fixed.

For the social sites, don't enter the https://... in the skins settings, since it is already hard coded in the footer.tpl I think all it needs is the social site account name.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
SteveX
SteveX
@ultrajam
6 years ago
2,583 posts
I agree with your first point, it should be jrCore_system_name

For the social links, are you entering "https://twitter.com/" as part of the profile url in skin settings? You should just enter the profile_url e.g. "jamroom" rather than "https://twitter.com/jamroom"
                        {if strlen($_conf.jrElastic2_twitter_url) > 1}
                            <a href="https://twitter.com/{$_conf.jrElastic2_twitter_url}">{jrCore_image image="sn-twitter.png" width="40" height="40" class="social-img" alt="twitter" title="Follow @{$_conf.jrElastic2_twitter_url}"}</a>
                        {/if}
Then both the url and the link title (Follow @jamroom) will be correct.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
blindmime
@blindmime
6 years ago
772 posts
I get it. In the second point, I'm just saying it could be done more clearly. What you're asking for is not really a URL. You're asking for a user or profile name. So why not put that in the form?

I realize it's not really a big deal and most of us figure it out and work around it. Just saying you might consider fine tuning things there.
updated by @blindmime: 01/20/18 07:04:02AM
douglas
@douglas
6 years ago
2,767 posts
I've got the social links checking for https: in the skin settings now for the next release, this is how I did it.

{if strlen($_conf.jrElastic2_facebook_url) > 1}
    {if $_conf.jrElastic2_facebook_url|strpos:"https:" !== false}
        <a href="{$_conf.jrElastic2_facebook_url}">{jrCore_image image="sn-facebook.png" width="40" height="40" class="social-img" alt="facebook" title="Like {$_conf.jrElastic2_facebook_url} on Facebook"}</a>
    {else}
        <a href="https://facebook.com/{$_conf.jrElastic2_facebook_url}">{jrCore_image image="sn-facebook.png" width="40" height="40" class="social-img" alt="facebook" title="Like {$_conf.jrElastic2_facebook_url} on Facebook"}</a>
    {/if}
{/if}

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
blindmime
@blindmime
6 years ago
772 posts
Another thing to think about, of course, is that each social network forms their URL's differently. For instance, if I just entered my LinkedIn user name in the Elastic 2 form I will get an error, since the URL is https://www.linkedin.com/in/username.

Also with your solution, the title will produce something like: "Like www.youtube.com/channel/UCexere_fdfdaeeerfddfd on Youtube". Maybe {$_conf.jrCore_system_name} would work better in the title tag? Although, some people will enter a SEO value for that which might not really work here either. Might be the better solution overall, however.
douglas
@douglas
6 years ago
2,767 posts
Hello,

I've got all skins updated to work with either a URL, profile name or profile ID, that will be in the next release.

I've also fixed the URL's if just a profile name or ID is entered.

Hope this helps!


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos

Tags