solved Player on custom skin broken after update

SteveX
SteveX
@ultrajam
11 years ago
2,587 posts
I have a site with a customised Nova skin where the audio player shows on all profile pages.

{assign var="ap" value="`$_conf.jrCore_active_skin`_auto_play"}
{jrCore_media_player type="jrAudio_blue_monday" module="jrAudio" field="audio_file" search="_profile_id = `$_profile_id`" autoplay=$_conf.$ap assign="profile_player"}

I've just updated core and modules, and the player now no longer works on some pages, it shows a text list as in the screenshot.

Surprisingly, the player breaks when I load another div with ajax, although the player is not part of the load. No console errors.

It appears to be related to having jrEmbed audio in the loaded div.
{$proj_summary|jrCore_format_string:$profile_quota_id:"embed"}

It works when that loaded content is loaded, then breaks when other content is loaded, then fixes itself again when relaoding the content with the embed. It was fully working on versions from about 2 weeks ago.

If there is no embed in the loaded content, everything works fine.

Has anyone else encountered this? Any idea where to look to fix it?

Thanks
player-problem.png
player-problem.png  •  23KB




--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

updated by @ultrajam: 05/04/14 11:34:26PM
SteveX
SteveX
@ultrajam
11 years ago
2,587 posts
It is something to do with the embed.

The problem occurs when using this for the embed (loaded via ajax, embed and main player work on initial load)
{$proj_summary|jrCore_format_string:$profile_quota_id:"embed"}
Everything works with this (but I lose the embed)
{$proj_summary|jrCore_format_string:$profile_quota_id:null:"embed"}



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
michael
@michael
11 years ago
7,806 posts
autoplay=$_conf.$ap
looks weird.

Does it play right if you just hardcode it to autoplay="true"?
douglas
@douglas
11 years ago
2,806 posts
This:
{assign var="ap" value="`$_conf.jrCore_active_skin`_auto_play"}
{jrCore_media_player type="jrAudio_blue_monday" module="jrAudio" field="audio_file" search="_profile_id = `$_profile_id`" autoplay=$_conf.$ap assign="profile_player"}

should be like this:

{assign var="ap" value="`$_conf.jrCore_active_skin`_auto_play"}
{jrCore_media_player type="jrAudio_blue_monday" module="jrAudio" field="audio_file" search="_profile_id = `$_profile_id`" autoplay=$ap assign="profile_player"}



--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
SteveX
SteveX
@ultrajam
11 years ago
2,587 posts
Thanks Michael and Douglas,

I had tried it and it behaved the same with autoplay=true


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
michael
@michael
11 years ago
7,806 posts
The image looks like its missing the CSS for the player.

Are the players working on a default skin. (if yes then we need to figure out whats different between the two.)

If no, are there any javascript errors in the console. (guessing that perhaps some js is broken which prevents other non-broken javascript from firing.)
douglas
@douglas
11 years ago
2,806 posts
Did you clone the Nova skin or are you using the Nova skin. You mentioned a custom skin so I'm assuming you cloned the Nova skin. Change the jrNova part in the assigned var below to your custom skin name and this should work.

{assign var="ap" value=$_conf.jrNova_auto_play"}
{jrCore_media_player type="jrAudio_blue_monday" module="jrAudio" field="audio_file" search="_profile_id = `$_profile_id`" autoplay=$ap assign="profile_player"}



--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos
SteveX
SteveX
@ultrajam
11 years ago
2,587 posts
Thanks Michael and Douglas.

Both the player and the ajaxed jrEmbed player work fine, no js errors. Its when the jrEmbed player is replaced that the main player loses its styling.

I've fixed this on my client site by turning off jrEmbed.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

Tags