solved Skin style editor bug with id selectors

There's a bug in the style editor which an be seen when an id is part of a selector with a color rule.

Whilst a color change will be recorded to the db, it is not possible to reset to the default if an id is present.

It seems to be fixed by urlencoding and decoding the selector between

line 5593 jrCore/index.php
jrCore_show_skin_style
Add $name = urlencode($name);

line 3669 jrCore/index.php
jrCore_css_reset_save
Add $_post['tag'] = urldecode($_post['tag']);



Also, any rule with !important in it will break the colorpicker js display:



Also, not having color selection for background and border is inconvenient.



I've spotted a couple of typos as well:

line 5219 typo: jrCore_notice_page('error', 'There do not appear to be aby CSS files for this skin!');
5432 typo // Our tag is used te let the user know what they are changing



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 02/03/14 01:34:58PM

Thanks Steve - I will check this out. I'm aware of some issues in the CSS editor and have had it on my todo list, so I will try to move that up in priority.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Just an FYI that there is support for background-color as well as border-color. The problem is that you cannot use "combined" rules - your border rule should be:


I will make sure "!important" works and fix up the typos.

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Can you show me an example of what your selector looks like for this?

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Ok, Thankyou Brian!


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

I guess I was replying to the wrong thread or something, who knows?




--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

Sorry for not following up on this much earlier - I'm checking this out and will see what's up.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

It looks like it was me who left the thread hanging - I probably got distracted by something else.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

This is fixed now in jrCore 5.1.9 - sorry it took me so long to follow up on this.

Let me know if you see any issues.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

After updating to 5.1.9 I no longer see any modules' css in the skin style editor.

Before updating there were 4 modules there (including jrUser and jrAudio), they all disappeared immediately after updating.

I've tried running the integrity check repairing tables and emptying cache, but the editable style sheets don't reappear.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

I do have some warnings in the error log from around the time I updated. The warnings aren't logged when I run the integrity check.

There is a warning for each of the core stylesheets:



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

That warning should be gone in the latest 5.1.9 - I saw that when fixing things up too. Not sure why the module CSS stopped showing - let me check that out.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Okay reload 5.1.9 and the module CSS should be showing again - let me know if you see any issues.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Yes, that brings them back.

The rules using ids are resetting perfectly as well.

Thanks


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

Glad to hear it - thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net