blog documentation FAQ followers forum marketplace services youtube

Empty module features headings showing

The Jamroom Network » Forum » Using Jamroom » Page » Empty module features headings showing
SteveX
SteveX
@ultrajam
11 years ago
2,589 posts
Looking at the docs page here:
https://www.jamroom.net/the-jamroom-network/documentation/development/1599/the-image-system

There is an empty Share This section showing. I probably don't have any share networks enabled.
share-this-title.png
share-this-title.png  •  56KB




--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 03/31/14 02:16:13AM
SteveX
SteveX
@ultrajam
11 years ago
2,589 posts
Also, when not logged in the share buttons show but comments and tags headings are showing.

They should maybe be hidden, or a notice saying you need ot be logged in to read comments.
not-logged-in.png
not-logged-in.png  •  40KB




--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 02/09/14 12:38:05PM
michael
@michael
11 years ago
7,821 posts
There just are no comments or tags for that doc yet. Ill add some.

comments you should be able to read logged in or out.

I cant see how to make it like your first screenshot. logged in and out i see the buttons.
SteveX
SteveX
@ultrajam
11 years ago
2,589 posts
Ah, the buttons aren't appearing because of my ad blocker.

Shouldn't comments and tags have an {if} around the header, or default text if there are none?


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
michael
@michael
11 years ago
7,821 posts
SteveX:...Shouldn't comments and tags have an {if} around the header, or default text if there are none?...

Yeah, I guess they should...maybe... not sure. Doug?

design concept I think. "You can comment here, but there arnt any yet so login and make one" vs "there are none, so dont even show the header."
brian
@brian
11 years ago
10,149 posts
The latest comments module should show a "you must be logged in to post a comment" box.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
douglas
@douglas
11 years ago
2,807 posts
The comments and tags are added to the profile pages by the jrCore_item_detail_features function, there isn't a header/title in the skin templates to add an if statement to, this would need to be done at the module level or the function showing the comments/tags on the detail pages.


--

Douglas Hackney
Jamroom Team - Designer/Developer/Support
FAQ-Docs-Help Videos

Tags