jrDeveloper Module License Headers comments break

SteveX
SteveX
@ultrajam
12 years ago
2,589 posts
Whilst it works fine if I already have a license header comment in include.php, if I do not it breaks the module created.

So this will break the module:
[code]



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

updated by @ultrajam: 06/28/16 07:26:41AM
SteveX
SteveX
@ultrajam
12 years ago
2,589 posts
Ah, it also breaks the bbcode.

Try again without the php tags:
Whilst it works fine if I already have a license header comment in include.php, if I do not it breaks the module created.

So this will break the module:
php

// make sure we are not being called directly
defined('APP_DIR') or exit();

/**
 * meta
 */
function ujIpsumJam_meta(){

Results in this output:
php
/**
 * Jamroom 5 Ipsum Jam module
 *
 * copyright 2003 - 2013
 * by Ultrajam
 *
 * This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0.  Please see the included "license.html" file.
 *
 * This module may include works that are not developed by
 * Ultrajam
 * and are used under license - any licenses are included and
 * can be found in the "contrib" directory within this module.
 *
 * Jamroom may use modules and skins that are licensed by third party
 * developers, and licensed under a different license  - please
 * reference the individual module or skin license that is included
 * with your installation.
 *
 * This software is provided "as is" and any express or implied
 * warranties, including, but not limited to, the implied warranties
 * of merchantability and fitness for a particular purpose are
 * disclaimed.  In no event shall the Jamroom Network be liable for
 * any direct, indirect, incidental, special, exemplary or
 * consequential damages (including but not limited to, procurement
 * of substitute goods or services; loss of use, data or profits;
 * or business interruption) however caused and on any theory of
 * liability, whether in contract, strict liability, or tort
 * (including negligence or otherwise) arising from the use of this
 * software, even if advised of the possibility of such damage.
 * Some jurisdictions may not allow disclaimers of implied warranties
 * and certain statements in the above disclaimer may not apply to
 * you as regards implied warranties; the other terms and conditions
 * remain enforceable notwithstanding. In some jurisdictions it is
 * not permitted to limit liability and therefore such limitations
 * may not apply to you.
 *

// make sure we are not being called directly
defined('APP_DIR') or exit();

 * meta
 */



--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
SteveX
SteveX
@ultrajam
12 years ago
2,589 posts
Is there going to be "Submit to the Jamroom Marketplace" functions or do the created modules just get downloaded and emailed to you by the developer?


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
12 years ago
10,149 posts
Ultrabubble:
Whilst it works fine if I already have a license header comment in include.php, if I do not it breaks the module created.

So this will break the module:
[code]


Yeah the developer tools expects you to have a small header like:

[code]
/**
* @copyright 2012 Talldude Networks, LLC.
*/
[/code]

but I'll see if I can get it to detect it.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
12 years ago
10,149 posts
Ultrabubble:
Is there going to be "Submit to the Jamroom Marketplace" functions or do the created modules just get downloaded and emailed to you by the developer?

No - what you do is:

1) package your module in the developer tools and download it to your Mac.
2) come here to jamroom.net and go to Marketplace in your profile, and create a new marketplace item.

Down the road I'm going to look at updating the developer tools so you can publish directly from there, but for now you need to download the ZIP and upload it as a marketplace item.

Let me know if that helps.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
12 years ago
2,589 posts
Yes, that all sounds good. Requiring a header in the files is probably a good idea anyway.

I did initially have a header in the files, I just removed them to get a feel for what was happening.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)

Tags