solved MediaProLight issues

Just purchased and installed MediaProLight. I think this skin has a lot of listings that will work for me out of the box!

So, 2 things I noticed:

1. site in developer mode, cloned skin, renamed to 4-letter skin name, I dont see the skin repopulate in the "SKINS" menu on left side. I did a refresh of cache and integrity check but it still doesn't appear. If I go back to developers tools > clone skin > I see the new skin in the pulldown. Again, just not in the main SKINS listing on left navigation in ACP.

2. I tried to swap out the logo. I select a new logo, hit save. I dont see the new logo appear in the images list, in jrElastic you would click it to be active then hit save. But I don't even get to that point.

Thanks guys,
B
updated by @ilovehousemusic: 03/28/14 11:31:31PM

BTW, I did try both Safari and Chrome...

I also tried to reload the skin, rename the skin longer name, and removed skins not in use to see if that skin menu would refresh. No dice!

also seeing this with using the 'clone skin' tool in the developer tools.

tried with 'xxDd' and 'xxDigg'. neither skin has appeared in the SKINS section yet.

files exist and look correct.

Digging further.

you can get to the skin at this url:
site.com/core/skin_admin/info/skin=skin-name


I think i see the problem.

In the include.php file for the skin the prefixes are all 'jr'.

So if you prefixed it with something other than 'jr' the function names are not going to line up.

I called my cloned skin: 'xxDd' but the include function is:
function jrDd_skin_meta()

I can see it now if I clone it to jrXXXX.

It looks like the image issue still persists:
2. I tried to swap out the logo. I select a new logo, hit save. I dont see the new logo appear in the images list, in jrElastic you would click it to be active then hit save. But I don't even get to that point.

Does the replacement logo HAVE to be the same size? In previous skins I tested, it simply resizes it.

I get the same result on the newly cloned skin mentioned above.

I'm not able to replicate this here - all functions are properly named in the include.php file after cloning.

You're running the latest jrCore (5.1.22)?


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Yes, I am on 5.1.22.

I also tried to upload a custom image, and then over write the header template using the new image code:
{jrCore_image module="jrILHM" image="ilhm_2014-420.png"}

It's weird I say...

I'm not talking about the custom images, but Michael has said that the function names inside include.php are not being renamed, and I am not able to replicate that.

Do you see that in your clone?

Also - try doing a FRESH clone - i.e. clone a new one, as previously it may not have worked right, but that should already be fixed.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

@brian I'll try that an chime back.

@brian - the cloning works (prior to 5.1.22) by using this format jrXXXX for the name.

After 5.1.22 the cloning works also, though I only tried "jrFreshClone". I didn't try anything shorter than 4-chars. Which is what I initially reported.

Still can't manage to change the logo on my site though. I've tried image override. Also uploading a new image, then overriding the listing in the template.

It really weird it works fine on jrElastic. It doesn't work for ProJam or MediaPro.

hope this helps!
Brian

Prior to 5.1.22 it would mostly work, but the regular expression that was matching the name for replacement missed some things - notably the CSS images. This is why you may need to manually go into your skin's css directory, and manually replace the {$jrElastic_img_src} with the right skin name.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

That's cool. I ended up doing it the "old school" way by uploading my new logo as "logo.png". You can close this! =)