blog documentation FAQ followers forum marketplace services youtube

Modules broken after updating jrEmbed

The Jamroom Network » Forum » Jamroom Developers » Page » Modules broken after updating jrEmbed
SteveX
SteveX
@ultrajam
9 years ago
2,583 posts
It looks like in the last batch of updates the entire tinymce popup system has been replaced with the sitebuilder widget system.

This breaks any 3rd party modules using the tinymce code.

It would be good to be given some advance notice of changes like this where working code is removed from all modules and replaced with something completely different.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
updated by @ultrajam: 05/22/15 11:39:09AM
brian
@brian
9 years ago
10,144 posts
SteveX:
It looks like in the last batch of updates the entire tinymce popup system has been replaced with the sitebuilder widget system.

This breaks any 3rd party modules using the tinymce code.

It would be good to be given some advance notice of changes like this where working code is removed from all modules and replaced with something completely different.

Steve -

My apologies - I was under the impression you had been notified (or was told you were being notified) - I'll follow up on that.

The Embed System has not been replaced with Site Builder - it was simply refactored to remove A LOT of redundant code that was being replicated by each module:

- the module embed template no longer needs to define prev/next page footer
- the "tab_ajax_modulename.tpl" file should now be called "jrEmbed_item_list.tpl" (although it is backwards compatible with the old name)

For the most part it should be backwards compatible unless you're doing something crazy.

Again I apologize if you were not notified - it was brought up a week or so before we released and you should have been notified.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
9 years ago
2,583 posts
Ah I see, thanks Brian.

Gary and Ken have both reported this error (although I'm not sure yet when that occurs:
{"notices":[{"type":"cri","text":"Query Error: Table 'gary_jamroom.jr_ujgooglemaps_item_key' doesn't exist"}]}

https://www.jamroom.net/ultrajam/forum/general/28547/latest-update-to-jrembed-broke
https://www.jamroom.net/ultrajam/forum/googlemaps/28551/error-code-after-update

Does this change mean that only modules using a datatore and having items to embed can use the tinymce popup? IpsumJam and GoogleMaps don't have any actual items of their own, yet they use the popup.


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
brian
@brian
9 years ago
10,144 posts
SteveX:
Ah I see, thanks Brian.

Gary and Ken have both reported this error (although I'm not sure yet when that occurs:
{"notices":[{"type":"cri","text":"Query Error: Table 'gary_jamroom.jr_ujgooglemaps_item_key' doesn't exist"}] }

https://www.jamroom.net/ultrajam/forum/general/28547/latest-update-to-jrembed-broke
https://www.jamroom.net/ultrajam/forum/googlemaps/28551/error-code-after-update

Does this change mean that only modules using a datatore and having items to embed can use the tinymce popup? IpsumJam and GoogleMaps don't have any actual items of their own, yet they use the popup.

I don't believe so - let me double check the code and see if there is a check happening that is preventing it from working.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
9 years ago
10,144 posts
Steve - I've just updated the Editor Embedded Media module to 1.3.1 - update and let me know if that fixes it for you.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
gary.moncrieff
gary.moncrieff
@garymoncrieff
9 years ago
865 posts
I can confirm that the error is gone and the options for these modules are loading again.
brian
@brian
9 years ago
10,144 posts
gary.moncrieff:
I can confirm that the error is gone and the options for these modules are loading again.

Awesome :)

Thanks Gary!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
SteveX
SteveX
@ultrajam
9 years ago
2,583 posts
That's great! :)

Thanks Brian, and thanks Gary!


--
¯\_(ツ)_/¯ Education, learning resources, TEL, AR/VR/MR, CC licensed content, panoramas, interactive narrative, sectional modules (like jrDocs), lunch at Uni of Bristol. Get in touch if you share my current interests or can suggest better :)
Ken Rich
Ken Rich
@ken-rich
9 years ago
926 posts
The Google Maps issue is fixed for me after update 1.3.1 (thanks) but I am still getting this with the construction kit.

":[{"type":"cri","text":"Unable to copy modules\/jrConstructionKit\/templates\/tab_ajax_sbconstructionkit.tpl to template cache directory: data\/cache\/jrCore"}]}


--

Ken Rich
indiegospel.net
brian
@brian
9 years ago
10,144 posts
Ken Rich:
The Google Maps issue is fixed for me after update 1.3.1 (thanks) but I am still getting this with the construction kit.

":[{"type":"cri","text":"Unable to copy modules\/jrConstructionKit\/templates\/tab_ajax_sbconstructionkit.tpl to template cache directory: data\/cache\/jrCore"}] }

I'll see if I can spot what the issue might be here. Note that now that the new Site Builder is in beta we're going to be helping users migrate to the new setup, as we won't be maintaining the old modules any longer.

I know you're running the current site builder beta on your "live site" so we will want to set up a time to move you over to the new setup.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Tags