solved jr6 - bug in the profile page timeline links?

Strumelia
Strumelia
@strumelia
7 years ago
3,602 posts
After updating to jr6, we're now getting a 'not found' error page for a certain type of link situation:

Seems to work fine?: the link to a group discussion from the Main Page/Index page activity Timeline.

Does not work: clicking the same link to a group discussion from a member's Profile Page Activity timeline. See the link in my screenshot from a profile page. Clicking that link takes me to http://fotmd.com/robin-clark/group_discuss/2012/developing-noter-drone-playing-the-melodic-style#cm132364 'not found'.
-Clicking same link from main page timeline takes me to the discussion correctly- and the CORRECT url would be: http://fotmd.com/strumelia/group_discuss/2012/developing-noter-drone-playing-the-melodic-style#cm132364
Here's the actual member page where you can see this happen: http://fotmd.com/robin-clark
The link is setting Robin as the group owner I believe, when actually it's my group, but his discussion thread.

Here's another example, when clicking on a different group discussion link from a different member's Profile page timeline:
http://fotmd.com/sleepingangel/group_discuss/2007/ebony-or-micarta-for-fingerboard-overlay#cm131658
That link 'should' be taking us to :
http://fotmd.com/guy-babusek/group_discuss/2007/ebony-or-micarta-for-fingerboard-overlay#cm131658
- you can see above that the link url is getting the item owner name wrong. The group belongs to Guy B., but the discussion was started by Sleepingangel.

Thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/13/17 04:10:34AM
michael
@michael
7 years ago
7,697 posts
looking into this now.
michael
@michael
7 years ago
7,697 posts
I've adjusted it in this template:
http://fotmd.com/comment/template_modify/id=242

and have used the post in your screenshot found here to verify its working:
http://fotmd.com/robin-clark/timeline

It appears to be correct now. At least for the current location. Could you check the known locations this issue is happening and confirm that it is fixed on your site please. If its fixed I will get this change in for everyone.

Thanks.
Strumelia
Strumelia
@strumelia
7 years ago
3,602 posts
I checked in three different places/instances... looks like it's working perfectly now Michael! Yay for your efforts!

What happens for me once you put out a general fix for everyone- will I need to then REMOVE your custom code of today because it will be redundant when i apply your update in the next Comment release? (I asked this in the other thread where you just fixed the other issue on my one site as well) Or will I just be leaving everything alone when apply the next jrComment update? -thanks for clarifying this.

I appreciate this getting fixed up - thank you!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015