solved notification options footer 3x repeating in "new user" email notification

Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
I'm having the "notifications adjust" footer get repeated 3 times on the emails I get whenever a new user signs up and is pending.
My User/ email preferences FOOTER simply says this:
---------------------------------------

If you would prefer to no longer receive event notifications, you can adjust
your notification preferences in your User Account:
{$preferences_url}
Or you can instantly unsubscribe from all notifications:
{$unsubscribe_url}

but see my attached pic for what I'm getting in my notifications for a new pending user.
footer.jpg
footer.jpg  •  556KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 08/17/16 06:45:30AM
michael
@michael
9 years ago
7,821 posts
This just started happening? Anything changed recently? Any updates to any modules that you can remember that happened around the same time?

I'll see if I can replicate here.
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
I remember seeing the triple footer at least two weeks ago, maybe three, but since it only seems to be happening for me on notifications for pending new member signups, I didn't may it much mind and didn't often scroll down enough to see it.
I'm watching my various other types of notifications now, but so far the triple footer I'm only seeing on the New Member pending email. Will update here if i see it in any other notification instances.

One clue: I notice that the WORDING is slightly different on the triple footer (in my screenshot) than in the footer template code I quoted above.
I know I adjusted the wording somewhere, can't recall where? I thought I only changed the wording in the User/ email preferences FOOTER template. But apparently not, since the wording is different in the two places. I tried to do a template search in modules and skin, and also in Filezilla site-wide, searching for "STOP receiving ALL site notifications"- precise wording which ONLY appears in the triple footer. But the search did not turn anything up. I know I wrote that wording, but now cannot recall exactly where, and can't find it through searching. :(
I also know that one or more of you JR team did some custom tweaks for me recently to try and prevent that issue where me and some admins were occasionally being unsubscribed from all notifications without our doing anything.- the ticket is # 26781 That tweak to make it harder to unsubscribe by accident 'might' possibly have some connection to this...?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
michael
@michael
9 years ago
7,821 posts
Don't think the two issues are related. I worked on the unsubscribe issue which will be out in the next jrUser module. It changes the premise from:
* you received the link in the email, so clicking it gives you access to unsubscribe because you know the url

to
* you know the url to unsubscribe, but if you're not logged in it is possible that you dont have login access, thats ok, so long as you do have email account access. (and sends a reconfirm opt-out link for non-logged in users.)

It seams like a different area to sporadic pending notification email footers.

It happens every time, or its intermittent? (hate intermittent things they are so hard to pin down.)
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
I've noticed it in the last few "member pending' type notifications...but it may have been happening for a while before that and I just didn't notice, because I don't typically scroll down to the bottom of such emails.
I most often get 1-3 new members every couple of days, so I'll have to let you know here if it's on the next one I get...hopefully within the next few hours.

That sounds like a very good module change Michael, thanks! :)

Michael, are you able to tell me exactly where to find my pending notification email footer code?- then I can at least check that the wording in the code is not accidentally tripled (unlikely, but I suppose possible that I could have made that dumb error somehow)...which would then be a simple fix for me to make. One problem is I haven't been able to find the dang location of that particular footer code, in order to check it. It's obviously different from the other usual email footer.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
Ok this is weird-
I just got an example from one of my moderators, and it's concerning a notification for a new post on a group discussion that she is following.
Here is the screenshot of the email she received yesterday (wednesday april 13):
Jans-footer.jpg
Jans-footer.jpg  •  429KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
...and here is a screenshot of the very same exact discussion 'new post' notofication that I received yesterday, and as you can see the footer did not triple for me:
my-footer.jpg
my-footer.jpg  •  419KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
(ugh, sorry to take up so much energy about this annoyance)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
michael
@michael
9 years ago
7,821 posts
This email:
---------------------------------------

If you would prefer to no longer receive event notifications, you can adjust
your notification preferences in your User Account:

{$preferences_url}

Or you can instantly unsubscribe from all notifications:

{$unsubscribe_url}

is found at:
/modules/jrUser/templates/email_preferences_footer.tpl
ACP -> MODULES -> USERS -> USERS -> email_preferences_footer.tpl

I've set my system to what I think is the same as yours, pending new users but i just get one footer for my email.

That 2 different location emails do the same thing with different email templates is interesting though. It points to the email template itself not being the culprit. Looking for why now.
michael
@michael
9 years ago
7,821 posts
Found a suspect.....

Question: In the emails with multiple footers in them, are there multiple users receiving the same email?

--edit--
Suspect this is the issue. The email is being sent out to multiple users and each time an email is sent an additional footer is added to the email.

So the first user gets one footer, the second gets two, the third gets three.

I've added in a check to make sure this doesn't happen in jrUser ver 1.8.5 but it doesn't explain the different email footer messages as is seen in your screenshot. Still concerned that is not yet fixed.
updated by @michael: 04/16/16 01:27:06AM
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
Michael, yes I was getting the triple footer report from a moderator of mine who is one of like 7 of us admins who are 'following' discussions in our private moderator Group. So yes those email notifications get sent to several of us.
I just applied the jrUser update yesterday, so I'll ask that moderator if the footers are not doubling/tripling now for her. Will report back here if it seems fixed. Thanks! :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
michael
@michael
9 years ago
7,821 posts
Thanks. :)
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
My moderator has reported back to me that she is no longer seeing duplicated footers on her various notification emails. Your fix in jrUser worked- thanks so much Michael! Marking this solved. :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015