solved Profile info tabs and name still showing up when clicking "ALL" Group discussions

Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Not sure where the thread is that I posted this in a while back, but I'm still having a bit of a problem with this.

When I am signed in as a regular member...
I click on the main GROUPS link, and then click to a particular Group.
On the Group's main page, all is well...see this first screenshot:
Grouppage.jpg
Grouppage.jpg  •  418KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 05/06/15 10:09:17PM
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Then, if I click on the link to show "All" discussions in the group, it takes me to this page, where suddenly the name of the person who created the group and all their personal content tabs are splashed across the whole top of the page...when it really should be the Group name or something instead. See screenshot. Using ningja skin.

This presents a problem especially for my site because I have created 90% of the 60 odd groups, and will continue to be the one who cretaes groups. It just looks dopey to me to have my name and personal content tabs be the biggest honkin' thing on the page when people go to browse all the discussions in my site's Groups. Too 'in yer face'. ;) Please help?

discuss_group.jpg
discuss_group.jpg  •  492KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/23/15 07:02:05PM
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Might I get some help with this issue please?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
10 years ago
10,149 posts
I'm not seeing an issue with this here on our demo site. Here's the group view


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

updated by @brian: 03/25/15 06:12:27PM
brian
@brian
10 years ago
10,149 posts
And here's the "All Discussions" view - you can see the profile header is identical between the 2. I would check your templates for any customizations that has removed the profile header from your group view.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Which template should I check for the differences in?-- differences I mean between my custom SKIN and the Ninja SKIN? Or in one of the jrGroup modules?


p.s.- uh, it's that I WANT to remove the profile name and personal content tabs in my second screenshot, so they are not present in the "all discussions" page. Your screenshots have them presnt in both views.

-if I recall correctly, I think I may have applied a little snip of code from Soaring eagle to remove that stuff in the individual Group home page....hmmm... now i need it GONE as well in the all group discussions page.

Did YOU guys not add a code change to do this as in my first screenshot? I thought you had addressed it later on after saoring had posted a codelet.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/25/15 06:24:55PM
brian
@brian
10 years ago
10,149 posts
Strumelia:
Which template should I check for the differences in?-- differences I mean between my custom SKIN and the Ninja SKIN? Or in one of the jrGroup modules?

It would be the jrGroup/templates/item_detail.tpl - that's the main "group" template.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Are you understanding what it is that I'm wanting Brian?- to REMOVE the profile name and their personal line of tabs from my Group "all discussions" view....as I 'somehow' successfully removed from my main individual Group page.

Are these two screenshot areas codes BOTH found in the same item_detail template?

Wouldn't the change I want to make be in the Group_discuss module?





--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/25/15 06:51:36PM
brian
@brian
10 years ago
10,149 posts
I'm sorry - I thought you were trying to figure out why the profile header was showing in the second screen - I wanted to point out that it is "supposed" to be there in the first...

However, I'm not sure how you removed the profile header from your first - it's not part of the item_detail.tpl. How did you remove it from the first? Are you sure the header is not still there and just "underneath" the main site header (which is floated on TOP of the body content)?


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
I can't quite remember how I did it now. =8-|
Should I post my whole code for my jrGroup support item_detail template here? I can if you want.

(p.s. I think it's my BRAIN that is "...not still there and just "underneath"...floated on TOP of my body content") l o l


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/25/15 06:59:50PM
brian
@brian
10 years ago
10,149 posts
No - you don't need to post the template - it's not actually affecting this.

Quick question just so I am sure I understand what you're looking for: You want it so when viewing ANY page inside a group (the group itself, the discussions, etc.) that you want it to NOT appear to be part of a profile - i.e. hide the profile header and sidebar?

If that is what you're looking it's not really going to be easy to do in templates - we would have to make this be some sort of config option in the NingJa templates and code in the necessary pieces (since part of this is NOT controlled by the group templates).

With Paul out of town and Michael and I busy on Site Builder it may be a little bit, but we can get that down as a TODO item for the next NingJa release.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Yes that is what I would want, ideally:
"You want it so when viewing ANY page inside a group (the group itself, the discussions, etc.) that you want it to NOT appear to be part of a profile - i.e. hide the profile header and sidebar?"

If you guys could get that into the next Ningja skin release (and tell us which templates to find the changes in!) and also get this other combined-video thing in that Ningja update as well:
https://www.jamroom.net/the-jamroom-network/forum/my_posts/27117/video-content-box-module-on-profile-pages-must-coordinate-or-change

Well that would be a cause for huge celebration! oooooh! (rubbing hands together with gleeful anticipation...)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
10 years ago
10,149 posts
This should all be taken care of now in the latest:

NingJa Skin
Profile Groups
Profile Group Discussions
Profile Group Pages

Update to the latest of all and you should be set. You'll want to compare your custom NingJa templates with the latest NingJa templates using the "compare" tool and the list of templates that were changed as provided in the Change Log:

https://www.jamroom.net/the-jamroom-network/networkmarket/165/ningja-skin?expanded_changelog=1

Hope this helps!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
This is exciting!! You JR fellers sure work fast! :)

I see most of the changed templates named there in the changelog (thank you!!!)
but not sure which skin templates to 'compare' for these items?:

- New: "Show Profile Header" skin config option to show Profile header when viewing groups
- New: Added support for new Combined Audio and Combined Video modules






--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/26/15 12:39:33PM
brian
@brian
10 years ago
10,149 posts
The changed templates are listed in the change log I linked to above:

- index.tpl
- profile_index_discussion.tpl
- profile_index_image.tpl
- profile_index_music.tpl
- profile_index_timeline.tpl
- profile_index_video.tpl

Let me know if you see that.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Just to get this clear- so after updating everytrhing (modules AND ningja skin)...I should do the 'compare' on those templates in my SKINS, right?- NOT doing the template compares within the modules themselves? So I'll be comparing my current active Custom SKIN profile_index_discussion.tpl with the new updated Ningja SKIN profile_index_discussion.tpl.... right?

(Just trying to get better at doing this on my own)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
10 years ago
10,149 posts
Correct, but you will need to do templates for the modules as well as they contain a new function to "hide" the header.

You can use the compare function for the Group, Group Discussions and Group Pages module just like the skin. The changed templates are also included in their changelog.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
OK, but I don't have 'custom' modules...only a custom skin.

After updating, I have jrGroupDiscuss/item_detail.tpl (1.0.10)... and I DO see the new change in it ({ jrProfile_disable_header }, near top)...but I can only 'compare' it to older versions before the update. Not sure what I'm supposed to be DOING there? Or is it fine after I see the code update there in the module and I just leave it all now updated and good to go except for my skin compares?
I AM seeing the updated code in my updated modules templates...so I supposed to actually "DO" something aside from just updating the modules such as jrGroupDiscuss in my ACP? Am I supposed to do something from my SERVER side?

I DO know how to go through the updated ningja skin and move changes into my custom skin....so I'll be doing that. But not clear on what I;'m supposed to do inside the module templates (if anything) aside from simply updating the modules from the ACP.



--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 03/26/15 01:19:02PM
brian
@brian
10 years ago
10,149 posts
if you have not customized the module templates, then you don't need to do anything - you should be good to go. This only applies to templates you have customized in the ACP.

Let me know if that helps.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
Ok i want to throw myself off a cliff- I just tried updating my custom skin and wound up royally screwing myself. I just posted a support ticket.... please help me..... !


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
Strumelia
Strumelia
@strumelia
10 years ago
3,605 posts
I was saved from hurling myself over the edge of the cliff.

This original issue for this thread about the profile info showing where it wasn't wanted is now SOLVED. :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015