solved bug in template Compare Tool, in jr6

Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
The template title in the Compare tool does not change correctly to the version you are trying to compare, even though you are changing the versions in the dropdown menu and even though you can tell from the code that it's the correct version in the right panel...the top title remains stuck and incorrect, so it's confusing and makes you nervous about transferring changes. See screenshot. (the tool works correctly in jr5)
compare-tool.jpg
compare-tool.jpg  •  375KB




--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

updated by @strumelia: 04/04/17 06:38:27AM
michael
@michael
9 years ago
7,806 posts
thanks. We'll get this fixed up. There were some changes in this area that allowed for over-ridden templates to be compared to their default.

So if your skin has a:
/skins/(YOUR SKIN)/jrAudio_item_list.tpl

file that file is over-riding the default item_list.tpl found in the audio module at:
/modules/jrAudio/item_list.tpl

But the compare tool did not allow that to be compared. Now it does. Its likely that the issue you're seeing is a result of something that needs to be added.

We'll get it fixed up. Thanks.
Strumelia
Strumelia
@strumelia
9 years ago
3,605 posts
Yes I noticed the advanced ability to compare versions- good job.
Thanks for fixing up this little quirk so that folks will be less confused. :)


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
brian
@brian
9 years ago
10,149 posts
Yeah I see this too and will get it fixed up.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net
brian
@brian
9 years ago
10,149 posts
I have this fixed for the next core release.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net