solved Lost the trashcan/delete icon on Index page Timeline in jr6?

On my jr5 live site, I have the nifty 'delete' trashcan for items on both profile page Timelines and on the Home/index page Timeline of my site. This hover trashcan enables admins to delete an item's mention from the activity feed (without deleting the actual item from the site).
On my jr6 (non-live site), I seen that a 'link' icon has now been added for both the Index page and Profile page Timeline entries. The link icon takes you to the Timeline page for that item, such as: yoursite.com/profilename/timeline/9 That's a cool new feature (though I'm not sure why it doesn't take one to the actual item instead of to its mention in a timeline- seems it would be more useful to take one to the actual item where it exists, like a comment on a photo for example).

HOWEVER on to my subject- On my jr6, the Trashcan icon is now missing from the Main/index page Timeline entries. It's still there on profile page Timeline entries. It's SO convenient for admins and moderators to be able to quickly remove a particular mention from the home page activity feed (without removing the item itself). This covers occasions like if a member keeps editing their video description over and over- we can remove lots of those so they don't take up the whole main page timeline. Or if some member says something I don't want to actually delete, but I dont necessarily want it broadcast on the main page of the site.

How can we get back the trashcan delete feature for the Homepage Timeline entries in jr6? Thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 04/02/17 11:21:41AM

That "link" icon links to the page for the specific action item (i.e. detail page for the action). This allows for things like comments on a timeline entry, ratings, etc. Since it is all templated you can change that if needed.


I have a feeling this is something you added in yourself custom to your JR5 skin - can you confirm that? Typically create/modify/delete are only available ON profile since we can be sure the "user_active_profile_id" is accurately set - otherwise if you delete an item that belongs to a profile that is NOT the active profile ID for the admin, then the wrong cache is reset.

Thanks!


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Brian, to me a bit to search back to find the trashcan timeline subject, but....this all came as a result of the following two threads back in September.
Several of us were asking to be able to delete Timeline items directly from the timeline, and Michael gave us a code and method to do it-

As in the last part of this thread:
https://www.jamroom.net/the-jamroom-network/forum/new_posts/43430/data-browser-truncates-out-timeline-profile-id-s-that-i-need#p43510

and the latter part of this subsequent thread:
https://www.jamroom.net/the-jamroom-network/forum/my_posts/43105/editing-activity-timeline

I transferred those modifications to my jr6 (non-live) site, and now it's only partly working.
I'm going to go into my jr6 template and make sure the codes that Michael gave in those two threads are in there properly. I coulda sworn it was working a little while ago, but I'll check that template to see if the code is still there unaltered. Then I'll post back here if i find anything or resolve it.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 12/30/16 04:31:46PM

Ok, I went to look at my index_activity.tpl in my active skin on my jr6 site...of which I had started the whole site by cloning over my jr5 site (including my custom ningja-based skin to start from). I was pretty confident I could apply or adjust the trashcan codes to it just like I did successfully in my jr5 template.

But what I see is weird- first of all, in my active skin my index_activity.tpl is named index_activity_off.tpl ...and I never changed its name like that ("_off", what does that mean?). Perhaps one of the JR Team did when doing something to help me?- I have no idea.
But the index_activity_off.tpl code seems to be quite different from my jr5 site skin's index_activity.tpl Not sure why there are so _many_ differences in those two templates- the 5 and the 6- is that the result of going to version 6 maybe? Brian, I know you helped me through the activity feed 'array' issue as I was upgrading that site to jr6. Had you done some changes to that template yourself maybe, or renamed it with the "_off"?

In any case, I couldn't find the timeline trashcan icon codes in it that I originally had from my jr5 cloned skin, nor could find the same places to insert it as I did in my jr5 template. I did try inserting it in one seemingly logical place, along with the script at the bottom (as in Michael's codes)...but it didn't work so I removed what I did.
Not sure why my jr5 custom skin's index_activity.tpl is now named index_activity_off.tpl in my jr6 custom skin...and i don't really know why its code contents seems so different. Does this template even function with its name including "_off"?

I don't know how to proceed now to get back the "admin delete timeline entry directly from timeline" function with its trashcan.


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015
updated by @strumelia: 12/30/16 05:41:10PM

Yes - that was me - you no longer need that template, so it can be removed. By NOT using that template you instead are using the module provided templates, and therefore don't have to worry about a skin override template.

So now the template you want to customize is going to be in the Timeline module - i.e. index.tpl.

Let me know if that helps.


--
Brian Johnson
Founder and Lead Developer - Jamroom
https://www.jamroom.net

Aha so it was YOU! lololol
Ok I'll look into it and post back. thanks!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

Ok, so I didn't see a logical place to add Michael's code into my Timeline/Action module's index.tpl.... BUT I did see a seemingly logical place to add it after a delete button mention in the jrAction module's item_list.tpl. So I added it there just the one place, and also added the little "are you sure you want to delete this?" script at the bottom. Hey, whaddya know, it worked! =8-o
Got it working great now. Yay! Will mark this solved.

Hey Brian, I'm hoping to update my main live dulcimer site (fotmd.com) to jr6 like this Monday or Tuesday- will you be around to help me with that 'array' tweak and just in case something goes wrong? Which would be a better day for you where you might be around?


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015

Well done Strumelia!!

Someone will be around.

--edit--
Worst case scenario: you delete the custom jrAction_item_list.tpl file you have in your skin and the default one gets used again and you site starts working. Then you can re-add your customizations to the working template.
updated by @michael: 12/31/16 12:48:35PM

Thanks Michael!
Actually, I don't have jrAction_item_list.tpl in either of my site's active skins. But I do have item_list.tpl in my Timeline modules on both sites- I added your code to the one on my non-live site (which was the only one not working)...and it just worked by some miracle. Just a lucky guess in my putting it where I did. ;D

Ok, when i sit down to start the 6 upgrade process on my LIVE site monday or tuesday morning, I'll first re-open my last ticket I had going with Brian when we were talking about upgrade and 'array' issues during when i upgraded my non-live site several weeks ago. I'll make sure if anyone is there just in case I blow something up by accident. lol

Thanks Michael and Brian!


--
...just another satisfied Jamroom customer.
Migrated from Ning to Jamroom June 2015